Thanks @ikalash!

Thanks @xylar for that fix! Sorry for introducing this bug in the first place.

@kliegeois, ah thanks for pointing that out! I hadn't realized the change was introduced recently but that explains a lot! No worries!

@ikalash, how hard would it be to introduce an Albany build to your testing that uses the settings we're using in Compass (albany+mpas~py~epetra+unit_tests)? I think such a test would have caught this problem.

@xylar : it would not be hard. We are currently testing the following build: albany@develop%[email protected]+mpas+py+optimization+mesh_depends_on_params+omegah. I would suggest to add ~epetra and +unit_tests to this build to avoid having multiple nightly test builds. @mperego are you OK with this?

@ikalash, the critical piece is actually the ~py (not having the python interface). That would almost certainly have to be a separate test, since you will also test with python. If you just want one test, I think what you've got it the better option.

The ~epetra+unit_tests options should be the defaults. I just specified them explicitly because I was getting builds with epetra for some reason and I wanted to make sure I wasn't getting passing builds only by skipping the unit tests.

@xylar : I see - I misread the ~py, sorry. Yes, I could add the new build. I'd do it probably on a different machine since there is already so much testing happening on camobap. I'll let you know when the new nightly build has been setup.

I think we're only using the spack build for compass currently? In which case, it makes sense to me to test what compass is using. i.e. probably don't need a new build.

Eventually it probably makes sense to have all testing through spack builds but I think we're still far from that.

I think we're only using the spack build for compass currently? In which case, it makes sense to me to test what compass is using. i.e. probably don't need a new build.

Do you mean Xylar is using compass for the spack build? Just to be clear, my nightly tests do not do anything with compass, they just build Albany.

xylar is using the albany spack build for compass. I'm not aware of anyone else using the albany spack build.

xylar is using the albany spack build for compass. I'm not aware of anyone else using the albany spack build.

But the error @xylar reported was from building Albany, no?

It looks like @xylar 's build line is:

albany@compass-2024-03-13%[email protected]+64bit+confgui~debug+epetra~fpe~ipo+landice~mesh_depends_on_params+mpas~omegah~optimization~perf~py~sandybridge~sfad+unit_tests build_system=cmake build_type=Release generator=make sfadsize=4 arch=linux-sles15-zen3

so he is building Albany with compass.

right, so I would just use those same settings in our nightly testing of albany spack. but feel free to add another build, I don't see any issue with that.

@ikalash, the @compass-2024-03-13 tag is a specific tag of Albany for use in Compass. It doesn't build Compass or have anything else to do with Compass other than being the version for us to use.

You should not do your nightly tests with that, obviously, because you want to test the latest master or develop or whatever. You also should not include that whole build string above, just albany@develop+mpas~py~epetra+unit_tests if you want to mimic the Compass spack build because the others were determined by Spack, not requested by me.

@ikalash, the @compass-2024-03-13 tag is a specific tag of Albany for use in Compass. It doesn't build Compass or have anything else to do with Compass other than being the version for us to use.

You should not do your nightly tests with that, obviously, because you want to test the latest master or develop or whatever. You also should not include that whole build string above, just albany@develop+mpas~py~epetra+unit_tests if you want to mimic the Compass spack build because the others were determined by Spack, not requested by me.

Thanks for clarifying @xylar , I think we are on the same page as I understood things the way you explained.

@ikalash it might be good to have two spack builds for testing, one with the minimal options used in the compass build and then the one you have now. Maybe we can reduce the frequency of the nightly builds so that we do not use too many resources.

I think we should get rid of the Epetra option, since it's ignored by Albany anyway now.

@ikalash it might be good to have two spack builds for testing, one with the minimal options used in the compass build and then the one you have now. Maybe we can reduce the frequency of the nightly builds so that we do not use too many resources.

Yes, this is what I was planning to do.

I think we should get rid of the Epetra option, since it's ignored by Albany anyway now.

I can do this.

Great. Thanks.

Just to follow up, I created the spack build we were discussing to run nightly on CEE and sends an email about the tests passing/not. @xylar let me know if you would like to be added to the list of people who get an automatic email about this daily.

@ikalash, I appreciate the offer. I think at least for now I'd prefer not to be part of the daily emails but we can re-evalute later if it seems useful for me to follow.

@xylar I understand. I will not spam you with the emails :).

Thank you @ikalash for creating the spack build!